promise icon indicating copy to clipboard operation
promise copied to clipboard

Published 20 hours ago • verified publisher icon reactphp

Add PHP 8.4 to the CI and fix implicit nullable types

Open nicolas-grekas opened this issue 1 year ago • 3 comments

Cherry-picking from #258

nicolas-grekas avatar Mar 19 '24 10:03 nicolas-grekas

(I'm now looking at why the job fails on 8.4)

nicolas-grekas avatar Mar 19 '24 10:03 nicolas-grekas

Now green on PHP 8.4. All it needs is the latest version of phpunit (not tagged yet)

nicolas-grekas avatar Mar 19 '24 11:03 nicolas-grekas

Great, thanks for listening to feedback :)

Seldaek avatar Mar 26 '24 19:03 Seldaek

Is there any expected date for new release compatible with fixed nullable types? PHPstan depends on it and it will be helpful to prevent this deprecations

andypost avatar May 08 '24 19:05 andypost

I opened a new pull request in #260 for this. The ongoing development in PHP 8.4 is currently breaking our test suite (changed stack trace -> failing .phpt test files), which will be visible in here once we'd rerun the currently green test suite (last executed on 2024-03-19).

I created a new proposal, which follows the original pull request from @Ayesh in #258. I tried to reopen the old PR, but couldn't do so as the created fork was already removed. Once #260 is approved and merged, it will automatically close this PR here as well.

Sorry for the back and forth, but I think we've come to a viable solution now. Thanks for everybody who contributed to the discussion :+1:

SimonFrings avatar May 14 '24 09:05 SimonFrings