siddarth.msv

LGTM Only reservation I have is resetting the pickupMap in the `iterator.HasNext()` between successive iterations. Because this way we'd only be picking up `discarded` number of jobs in further iterations....

One other thought is that since we query by `job_id` as well now, we could use ``` type dataSetRangeT struct { minJobID int64 maxJobID int64 startTime int64 endTime int64 ds...

We'd also want to have a memory limit over how the `jobIterator` fetches jobs right..? Because every iteration it could fetch many jobs and `discard` them and all these jobs...

Approved Maybe the `module` tag in the stats is unnecessary if the name already consists of the module name.

pertinent transformer [PR](https://github.com/rudderlabs/rudder-transformer/pull/1415)

> @Sidddddarth would you mind giving a bit more context about this PR? What is the motivation behind this change? https://rudderlabs.slack.com/archives/C0218DFG57D/p1657798156457899 https://rudderlabs.slack.com/archives/C02B0A38QQG/p1657721887565259 We're basically trying to add another layer of...

There's a `users` table name in use in `warehouse/integrations/snowflake/snowflake.go:1044`. Maybe add it to the new map or use `TableNameForStats`? Same in `warehouse/integrations/deltalake/deltalake.go:1172`

> We open a file with append flag file, err := os.OpenFile(s, os.O_WRONLY|os.O_APPEND|os.O_CREATE, 0o660) , not sure what the original intention, but the expected behaviour if we fail to write...

> If you wait for `server.Shutdown` to return normally all the open connections will have been completed. True. > Why this approach is not enough and we have to introduce...

the `gracefulFunc` in `kithhtputil` can return an error other than one on `server.Shutdown` too, which prompted me to go with a counter. ``` func ListenAndServe(ctx context.Context, server *http.Server, shutdownTimeout ...time.Duration)...