rudder-server
rudder-server copied to clipboard
chore: reducing metrics cardinality
Description
- Restricting tableName in warehouse stats to be from one of these []string{"tracks", "identifies", "pages", "screens", "aliases", "groups", "users"}, otherwise use others.
Linear Ticket
- Resolves PIPE-1067
Security
- [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.60%. Comparing base (
1aadeb0) to head (c7f7e82).
Additional details and impacted files
@@ Coverage Diff @@
## master #4662 +/- ##
==========================================
+ Coverage 74.59% 74.60% +0.01%
==========================================
Files 412 413 +1
Lines 48699 48703 +4
==========================================
+ Hits 36325 36334 +9
- Misses 10001 10012 +11
+ Partials 2373 2357 -16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There's a users table name in use in warehouse/integrations/snowflake/snowflake.go:1044.
Maybe add it to the new map or use TableNameForStats?
Same in warehouse/integrations/deltalake/deltalake.go:1172
There's a
userstable name in use inwarehouse/integrations/snowflake/snowflake.go:1044. Maybe add it to the new map or useTableNameForStats?Same in
warehouse/integrations/deltalake/deltalake.go:1172
Added users as well in statsSupportedTableNames.