rudder-server icon indicating copy to clipboard operation
rudder-server copied to clipboard

chore: add destType in tags and remove from name

Open cisse21 opened this issue 3 years ago • 2 comments

Description

Batch Router stats have the destinationType in the stat name causing difficulty in grouping by destType on Grafana. This PR attempts to add them as tags.

Also removed a redundant table count stat from jobsdb

Notion Ticket

Notion Link

Security

  • [ ] The code changed/added as part of this pull request won't create any security issues with how the software is being used.

cisse21 avatar Sep 06 '22 03:09 cisse21

Codecov Report

Merging #2391 (61d9cf5) into master (8ef6c39) will increase coverage by 0.01%. The diff coverage is 25.00%.

:exclamation: Current head 61d9cf5 differs from pull request most recent head 6a1b252. Consider uploading reports for the commit 6a1b252 to get more accurate results

@@            Coverage Diff             @@
##           master    #2391      +/-   ##
==========================================
+ Coverage   34.24%   34.25%   +0.01%     
==========================================
  Files         200      200              
  Lines       39547    39554       +7     
==========================================
+ Hits        13544    13551       +7     
- Misses      25130    25131       +1     
+ Partials      873      872       -1     
Impacted Files Coverage Δ
jobsdb/jobsdb.go 61.60% <ø> (+0.10%) :arrow_up:
router/batchrouter/batchrouter.go 33.44% <25.00%> (ø)
enterprise/suppress-user/suppressUser.go 82.71% <0.00%> (-1.86%) :arrow_down:
processor/processor.go 71.59% <0.00%> (-0.06%) :arrow_down:
gateway/webhook/webhook.go 61.21% <0.00%> (+1.37%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 06 '22 04:09 codecov[bot]

Approved Maybe the module tag in the stats is unnecessary if the name already consists of the module name.

Sidddddarth avatar Sep 06 '22 05:09 Sidddddarth

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

github-actions[bot] avatar Sep 28 '22 02:09 github-actions[bot]