chore: remove multiGzipWriter

[Sidddddarth]

Description

Use misc.GZipWriter in archiver since there's no need of a multi-file writer there.

Linear Ticket

Slack

Security

• [ ] The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Sidddddarth]

We open a file with append flag file, err := os.OpenFile(s, os.O_WRONLY|os.O_APPEND|os.O_CREATE, 0o660) , not sure what the original intention, but the expected behaviour if we fail to write on existing file should result in an error rather appending to the end.

An error is returned on failing to write in any case right?

No error is returned gzWriter.Write

It is returned..?

func (w GZipWriter) Write(b []byte) (count int, err error) {
	count, err = w.BufWriter.Write(b)
	if err != nil {
		pkgLogger.Errorf(`[GZWriter]: Error writing bytes of length %d by GZipWriter.Write. Bytes written: %d. Error: %v`, len(b), count, err)
	}
	return
}

In terms of naming, I would get rid of the GZ suffix in its method

We're creating a writer to a compressed file(gz so it makes sense to keep it no?) otherwise we wouldn't know reading stash/archiver code that we write to a gz-ending file. And it's nice wrt this functionality too, explicitly describing the writer

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 56.33803% with 31 lines in your changes missing coverage. Please review.

Project coverage is 74.68%. Comparing base (c9aa980) to head (4b05fff). Report is 23 commits behind head on master.

Files with missing lines	Patch %	Lines
processor/stash/stash.go	59.09%	13 Missing and 5 partials :warning:
cmd/backupfilemigrator/file_migrator.go	20.00%	4 Missing and 4 partials :warning:
archiver/worker.go	28.57%	2 Missing and 3 partials :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5016      +/-   ##
==========================================
+ Coverage   74.65%   74.68%   +0.02%     
==========================================
  Files         431      435       +4     
  Lines       50127    50495     +368     
==========================================
+ Hits        37423    37712     +289     
- Misses      10257    10288      +31     
- Partials     2447     2495      +48     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.