Shane Krueger

Results 854 comments of Shane Krueger

Just to recap, I really like this PR, but I would not merge it without #3273. As I see it, the main purpose of this PR is code cleanup --...

I suggest this PR be revised and reviewed after #1511 as the latter PR will slightly change the code in this PR.

I feel that we should consider moving this functionality to the Relay project. It may not be needed (or be able to be greatly simplified) now that the Relay project...

While perhaps not strictly against the spec, this scenario is not practical with GraphQL.NET.

Thanks, @joelmandell ! I'll take a look. Hopefully we can provide a sample that does not require the execution result to be serialized, deserialized, and reserialized again. But as you...

Also #2161 requested proper sample.

> https://github.com/graphql-dotnet/examples/blob/master/src/AspNetWebApi/WebApi/Controllers/GraphQLController.cs#L37 `WriteToStringAsync` is at least better. But we should not have to write the data to a memory stream, then read into a string, and then converted by ASP.Net...

@joelmandell Could you try this when you get a chance: ```cs [ApiController] [Route("[controller]")] public class GraphqlController : ControllerBase { public async Task Post([FromBody] GraphQLRequest q) { var schema = new...

See: - https://github.com/graphql-dotnet/examples/pull/91