Shane Krueger

Results 854 comments of Shane Krueger

Note that I do not have any pressing need for this change. It's simply that nullable reference annotations revealed to me that my error logging code could NRE if an...

Yeah. On a side note, `IExecutionContext` is currently rather pointless, as `IExecutionStrategy` requires `ExecutionContext`. Not only that, we have `internal` variables within `ExecutionContext`, making it so that we cannot easily...

> I m not talking about schema first. I m talking about **type first**. bcs it has more power. > > but at the end both will be entertained by...

There is a lot of work left before graphs can be completely “type first” but it is getting close.

@sungam3r I'd like to get this into 7.0 also.

@sungam3r While I would like to merge this for v7, if you want to delay it, then I can post a separate PR with only the necessary infrastructure bits that...

I looked through much of the available MS documentation on this topic. I cannot find any significant reason not to sign the assembly. Here's what I noticed: * On .NET...

@anderslaub Also, can you add a PR targeting the `develop` branch of the GraphQL.NET Server repository (https://github.com/graphql-dotnet/server) for matching changes? New for v7, GraphQL.NET Server supports ASP.NET Core 2.1 running...

You make a very good point; I've been thinking that we should stop publishing samples that do not use the server project, as many people copy from these samples which...

It's the `develop` branch from `graphql-dotnet/graphql-dotnet`.