Shane Krueger
Shane Krueger
Also I took another pass at simplifying some of the setup, along the lines that were discussed in the parser project. You can see it in #3281 . If you...
@sungam3r Please review if you like
@sungam3r I'm merging this so we can get the strong name PR done in the server repo. Lmk if you have any comments.
As it relates to the computed complexity factor, it should be easy with https://github.com/graphql-dotnet/graphql-dotnet/pull/3159 which was just merged -- setting the root introspection types to have an impact of zero...
Personally, I see the MaxDepth property having limited usefulness, because often extremely complex queries can be written with a very shallow depth. Example: ```cs { featuredProducts { similarProducts { similarProducts...
Node is only used for building the docs, right? Doesn't really matter what version it uses. And v16 is the current LTS version, so sounds fine to me.
Looks great, but now it seems we are in dire need of a sort property on `IConfigureExecution`. Otherwise adding a validation rule after calling `.AddMemoryCache()` would be disastrous. Not to...
I fixed the tests, but they will probably break again after #3273 , and I'll fix them again.
> GetAsync/SetAsync - Would you like me to make them protected? Protected probably makes more sense.
> Thanks. Mocks are not my strong skill. No problem. Admittedly the mocks in that particular set of tests are hard to code and have little practical value. They were...