Shane Krueger
Shane Krueger
I think surely for schema-first, input coercion could throw a better exception. I have not looked at the code for that yet, as I'm only vaguely familiar with how schema-first...
PR would be welcome also
I would remove IComplexityAnalyzer instead - see #3177
> The only drawback that I see here is the use of `AddXXX` methods instead of `UseXXX` similar to ASP.NET. The developers are accustomed to this terminology and for many...
> > Additionally, having a sort order allows to create plugins that install themselves at multiple points within the execution. > > How? Something like this: ```cs public static IGraphQLBuilder...
> Nevertheless, this proposal with the SortOrder property seems far from perfect to me. Maybe the problem can be solved somehow differently? I'm still listening, but changing `Add` to `Use`...
I suppose it is an option to deprecate the old `Add` methods without removing them.
So would `AddMiddleware` be `Add` or `Use`? It adds itself to the DI but also calls `FieldMiddleware.Use` in a specific order within the schema configuration ....
@sungam3r I'm looking at it, and it seems that `Use` would only apply to: - UseMiddleware - UseApolloTracing - UseDocumentCache / UseMemoryCache - UseAutomaticPersistedQueries We already have 'ConfigureSchema` and `ConfigureExecution`,...
I'm trying it, but the problem is that `AddValidationRule` also uses `ConfigureExecutionOptions` to add the validation rule. So essentially it because a `Use` rule also -- and indeed it matters...