Shane Krueger

Results 854 comments of Shane Krueger

If all is well and @sungam3r has no comments, I'll merge and release the parser 8.1.0, then you can fix up the GraphQL.NET PR, and we will merge that, and...

> https://github.com/graphql-dotnet/graphql-dotnet/blob/2ff8a9ac649215965437c95577afdab1f70d9111/src/Directory.Build.props#L4 > > this is called 7.0.0-preview We renamed 6.x to 7.x to align with server repo. There is no 6.x. Probably it's just an older beta build. Here's...

When we release GraphQL.NET 7.0.0 we will update the reference in the server repo to 7.0.0 of course.

Once the PR in the parser library is merged, even before 8.1.0 is released, we can reference the beta parser lib in GraphQL.NET so it is referencing a strongly-named assembly....

> Sure okay, then I just wonder why the test projects on `server:develop` doesn't build. But I leave it for now and wait for the releases. > > Btw; do...

As it relates to your previous comment, I think I follow. It is possible to release a 2.4.1 but we would need a PR to bring in the proper GitHub...

@anderslaub If you bump GraphQL-Parser to `8.0.0-preview-153`, which should have a strong name, then you should be able to make the necessary changes in this repository for all the build...

> From a more pragmatic viewpoint it'll probably be faster to get rid of the dependency in the test projects. I will leave that up to you. I think it...

Well, all the .NET Framework 4.8 tests failed (which only run on Windows), with an error about the strong name not matching. ``` [xUnit.net 00:00:01.83] Skipping: GraphQL.Tests (could not find...

@anderslaub I merged in #3278 and then merged develop into your branch. Then I fixed the workflows in your branch here so that it would pass the tests. Apparently when...