Brennan Ravenscroft
Brennan Ravenscroft
Would it be possible to allow server operators to adjust server configs while in SMP? It might be out of scope of this PR, but I just want to pose...
Last batch of changes looks good to me.
I don't think any part of this system can be expanded to `LivingEntity`. Most of it is concerned with the use of `FoodData` or is a patch of a method...
If the calls within `tick` are not really player-specific, you can add a method `tick(LivingEntity)` and make `tick(Player)` just call that one.
My opinion on it is that up-typing to `LivingEntity` could be done later by a different PR in 1.19 when breaking changes are permitted.
The following event hook calls should be converted to attributes on `LivingEntity` * getMaxHunger * getExhaustionCap The following tick-based event hook calls *could* be converted to attributes on `LivingEntity` *...
Then finally, all events except `PeacefulRegen` (both types) can be expanded to be `LivingEntity`
Would this be better implemented as a `SweepHitEvent` (similar to `CriticalHitEvent`) that allowed you to force, cancel, or modify the entire sweep attack, rather than just the hitbox as proposed?
This should be handled by #7916 when that gets completed.
As a new feature this needs to be added to latest before it can be added to an LTS version, additionally this is a breaking change as-is (removal of constructors...