MinecraftForge icon indicating copy to clipboard operation
MinecraftForge copied to clipboard

[1.16.x] Added ways to filter PlayerInteractEvent.LeftClickBlock Actions

Open DabbingEevee opened this issue 2 years ago • 6 comments

A quick and simple fix for how PlayerInteractEvent.LeftClickBlock fires on unfiltered on all 3 actions (https://github.com/MinecraftForge/MinecraftForge/issues/8643).

This is an implementation of the solution proposed by KnightMiner (https://github.com/MinecraftForge/MinecraftForge/issues/8643#issuecomment-1143084781).

DabbingEevee avatar Jun 01 '22 16:06 DabbingEevee

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 01 '22 16:06 CLAassistant

Is this through GitHub editor? Did you test your changes?

SizableShrimp avatar Jun 01 '22 16:06 SizableShrimp

Apologies, I meant to make this a draft. This is not yet ready for a merge

DabbingEevee avatar Jun 01 '22 17:06 DabbingEevee

image just tested, it does work

DabbingEevee avatar Jun 01 '22 18:06 DabbingEevee

As a new feature this needs to be added to latest before it can be added to an LTS version, additionally this is a breaking change as-is (removal of constructors is breaking). You'll need to deprecate those instead.

Shadows-of-Fire avatar Jun 09 '22 03:06 Shadows-of-Fire

Hello! @DabbingEevee, please leave a comment whether you wish to continue this PR and update it to the latest active version of 1.19.2 (or leave an explanation why this PR's changes are not applicable to 1.19.2). If we do not hear back from you after some time, this PR will be closed for inactivity.

If anyone else wishes to continue the work of this PR, please create a PR with a link to this PR for reference. Thank you for your contributions. 👋

sciwhiz12 avatar Aug 27 '22 18:08 sciwhiz12

Hello! As per my previous comment, we will be closing this PR for inactivity. If you or another contributor wishes to continue the work of this PR, please create a new PR with a link to this PR for reference. Thank you for your contributions. 👋

sciwhiz12 avatar Oct 12 '22 09:10 sciwhiz12