Brennan Ravenscroft

The quickest fix is to change the exception to a debug log error, but it doesn't really solve the problem that new villager type fishermen would still be selling empty...

IMO this is fine but it should probably be called `getLastAttackStrength` to clearly note that it is for the strength of the *previous* attack and not the attack strength at...

The other name I can think of is `getCachedAttackStrength` which is non-temporal (doesnt imply current/prev due to ambiguity) and also doesn't imply it's a "live" (always valid) property like `getAttackStrength`...

The event chain of reference here is potentially all of the following * LivingAttackEvent / AttackEntityEvent * LivingHurtEvent * LivingDamageEvent * LivingDeathEvent * LivingDropsEvent Making this field part of each...

From a conversation with lex on discord a while ago, cancelling the spawn is not the desired behavior (the javadocs are the ones incorrect) - cancellation of finalizeSpawn is the...

Convo link for reference, (internal channel): https://discord.com/channels/313125603924639766/887479168168775761/942495250298077204 However, given the discrepancy between the callsites, this issue should remain open until something is done. It might be advisable to change the...

Probably a while... it requires that it be merged in 1.19.x first and it's fairly involved, which means someone has to heavily test it.

This is not a good way to go about doing this. Render code should not be present or relevant to the server (which capabilities are), Capabilities also add other complexity...

PR's for events that fire on stack rendering have historically been automatically denied, so it may only be accepted as an extension to the client item interface

Just make the method default and return `Collections.emptyList()` to make it non-breaking. Then you also don't need all these default impl classes.