Brennan Ravenscroft

icon indicating a website link https://www.curseforge.com/members/shadows_of_fire/projects icon indicating an email [email protected]

icon location Author of various Minecraft mods, notably Apotheosis, Gateways to Eternity, Hostile Neural Networks, and FastWorkbench

Results 242 comments of Brennan Ravenscroft

[Suggestion][Request][1.12.2] Add aqua plants similar to kelp

Yeah it's something I would like to explore. I need to majorly redo plants to proceed forward into 1.14, so it may be a bit before any changes happen.

[1.20.5] Remove uses of `Event.Result` and update events to have their own Result classes

Still 92 compile errors. My original list is missing a few entries.

[1.20.5] Remove uses of `Event.Result` and update events to have their own Result classes

Remaining events: - [x] ~~FillBucketEvent~~ Deleted. This is a very old event (circa 1.2.5) that is fully superseded by `PlayerInteractEvent.RightClickItem` with an `item == Items.BUCKET` check. It also has been...

[20.6] Add tick level extension method to expose the client/server method for common usage

Tech, I fail to understand why you are so staunchly against this, the maintenance cost is zero and it solves a problem in a simple fashion. Your argument seems to...

Adding providers to `DataGenerator` via lambda is ambiguous

Is this just poor method resolution on javac's side? The two method signatures are ```java public T addProvider(boolean run, DataProvider.Factory factory); public T addProvider(boolean run, T provider); ``` There's no...

NeoForge mod not compiles

Visual Studio is not a supported environment. Even if it were, it appears to not support modern gradle versions: https://github.com/redhat-developer/vscode-java/issues/3648

[20.6] Add events to determine if item pickup should be allowed or not

Could guard it with a config option or a mod internal flag, but no we can't have it enabled by default due to Mojang's stance here.

[20.6] Add events to determine if item pickup should be allowed or not

I think having the option as a different NBT key is a good solution. Similar to the mostly-agreed upon "no magnetism" tag

[20.6] Add events to determine if item pickup should be allowed or not

Going to stop that review early. I think this has gotten too complex for the intended goal, which was just to mark certain items as being unable for pickup. If...

[20.6] Add events to determine if item pickup should be allowed or not

@ApexModder The PR needs to be rebased against 1.20.x to resolve conflicts.