servicetalk icon indicating copy to clipboard operation
servicetalk copied to clipboard

Re-evaluate usage of addSuppressed

Open lewisd32 opened this issue 7 years ago • 1 comments

discussed offline with @NiteshKant ... I think we should re-evaluate our usage of addSuppressed. In the face of static exceptions and addSuppressed may throw if the exception is the same instance this creates potentially undesirable behavior at the benefit of "maybe providing more context".

Originally raised here: https://github.com/servicetalk/servicetalk/pull/131#discussion_r232133741

lewisd32 avatar Nov 09 '18 18:11 lewisd32

I think this applies more generally than just CommanderUtils. Let me update the title

Scottmitch avatar Nov 26 '18 17:11 Scottmitch