Sarah French
Sarah French
Just a heads up - this would be a breaking change for the field ([see our guidance on this here](https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/breaking-changes/#field-level-breaking-changes)) and would need to be included in an upcoming major...
@Maarc-D sorry for the delay, this PR slipped off my radar! We'd need to double check what users will experience when upgrading from a previous version of the provider to...
Hi @LucaPrete - My review comments above describes the two routes forward for this PR/the [original issue](https://github.com/hashicorp/terraform-provider-google/issues/9353). @Maarc-D hasn't had enough time to respond to the review yet, but if...
Closing - stacked PR is replaced by https://github.com/GoogleCloudPlatform/magic-modules/pull/10106
Thanks Mau!
Update: I'm in the process of adding the ability to test this via TeamCity here: https://github.com/GoogleCloudPlatform/magic-modules/pull/10088
Using the diff from the latest report I've triggered tests in TeamCity here : https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_FEATUREBRANCHPROVIDERFUNCTIONS_MM_GA_GOOGLE_PACKAGE_FUNCTIONS/115271?mode=builds&buildTab=overview&hideTestsFromDependencies=false&hideProblemsFromDependencies=false
rebased to include the the latest synced commits on the feature branch that came from main - that should address the test failures above
@c2thorn - sorry for the notification spam this PR must have given you. This is now ready for review :) - the unrelated test failures are now resolved by syncing...