magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add `location_from_id` provider-defined function

Open SarahFrench opened this issue 1 year ago • 1 comments

This PR adds support for a new provider-defined function:

  • location_from_id

There are unit and acceptance tests for both of these, and documentation

Note about testing

Currently, testing this PR requires downloading an alpha release of TF 1.8.0 and running the acceptance test locally. The unit tests should work fine because they don't use a TF binary like acc tests do, and the dependencies on this branch include provider function support.

I'm working on adding automated testing for the feature branch and provider-defined function PR here: https://github.com/hashicorp/terraform-provider-google/issues/17451


Release Note Template for Downstream PRs (will be copied)

provider: added provider-defined function `location_from_id` for retrieving the location from a resource's self link or id

SarahFrench avatar Feb 27 '24 12:02 SarahFrench

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 27 '24 12:02 google-cla[bot]

Thanks Mau!

SarahFrench avatar Mar 01 '24 12:03 SarahFrench