Sarah French

Results 293 comments of Sarah French

Sorry, I've been pretty busy this past week! I'll review this PR on Monday

Nope, nothing more, I'll approve and merge. Thanks!

I found some config from the Composer tests didn't include dependencies between `google_composer_environment` and the related `google_project_iam_member` resources, so tests may attempt to create environments before the necessary permissions are...

I've updated this issue as it was a bit stale. The permissions issue is consistently seen for TestAccComposer1Environment_withNodeConfig and other tests pass without permissions issues.

Wondering if the above could be a race condition, as the tests passed ok during development... /gcbrun

I realised that I don't actually know if the provider is guaranteed to be re-configured between each step. The failure above looks like it's because the provider configured in step...

This failure is very confusing as I can see `Terraform is using this identity: ` before the POST request in step 2 that's triggering the error. So the provider is...

Ah, the error from attempting to use fake creds doesn't include any data about email so if I want to inspect the (fake) creds contents I'll need to surface it...

This PR has got too much noise in it now, so I'll split it into: - A PR for moving the validator tests into their own file - A PR...

https://github.com/GoogleCloudPlatform/magic-modules/blob/d690063bc59b8d3d3bf2699eb36d179f06b1d6a6/mmv1/templates/terraform/examples/kms_key_handle_basic.tf.erb needs to be updated so that the names of the resources as sweepable (start tf-test-) and are unique per test run