Remove ga-only logic from IAM test generation

[SarahFrench]

Closes https://github.com/hashicorp/terraform-provider-google/issues/12610

Need to check why code was like this & if it's ok to remove now

---

If this PR is for Terraform, I acknowledge that I have:

• [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 11 files changed, 441 insertions(+), 58 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

[SarahFrench]

google-beta/iam_compute_machine_image_generated_test.go:144:123: expected operand, found ','

Error from terraform-provider-google-beta-test check

Corresponds to this template code

ImportStateId:     fmt.Sprintf("<%= import_url -%> <%= object.iam_policy.allowed_iam_role -%> %s"<% unless import_qualifiers.empty? -%>, <% end -%><%= import_qualifiers.join(', ') -%>, <%= example.primary_resource_name -%>, context["condition_title"]),

producing this Go code:

ImportStateId:     fmt.Sprintf("projects/%s/global/machineImages/%s roles/compute.admin %s", getTestProjectFromEnv(), , context["condition_title"]),

Looks like the ga-only logic is needed due to beta versions lacking data like example.primary_resource_name in the yaml files.

This appears to only be true for some resources, so I think it may be a case of adding the missing data to the terraform.yaml files for the affected resources instead of closing this PR. I'll follow this up later...

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 11 files changed, 477 insertions(+), 83 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

[SarahFrench]

Rebased this PR as it's quite old (3-4months)

[SarahFrench]

API Gateway tests are being more of a pain - need to provide parent resource name when building the ImportStateId and it doesn't seem like the template handles this. Decision about whether to address quickly or whether bigger changes needed...

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 11 files changed, 395 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

[SarahFrench]

In the most recent commit I had a go fixing the acceptance tests that fail the 'new' test code (that's now included due to removing ga-only logic).

I changed the names and values of a bunch of var values and I learned about this code:

https://github.com/GoogleCloudPlatform/magic-modules/blob/4c59a62732d12c72dd8ae6aea1edc53564709326/mmv1/provider/terraform/examples.rb#L204-L217

It prepends tf-test- to vars only if the name already contains dashes. So I spent some time manually adding that prefix to var values, seeing that code generation added a second identical prefix, and then when I removed the hardcoded tf-test- I saw the automated addition of tf-test- also disappeared. Very annoying! The result is that I've left dangling dashes on the var values so that it triggers the automation.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 8 insertions(+), 8 deletions(-)) Terraform Beta: Diff ( 17 files changed, 449 insertions(+), 54 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 16 insertions(+), 16 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2424 Passed tests 2125 Skipped tests: 254 Failed tests: 45

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated|TestAccComputeMachineImageIamBindingGenerated|TestAccComputeMachineImageIamBindingGenerated_withCondition|TestAccComputeMachineImageIamMemberGenerated|TestAccComputeMachineImageIamMemberGenerated_withCondition|TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated|TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccApiGatewayGatewayIamMemberGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayGatewayIamBindingGenerated|TestAccApiGatewayApiIamPolicyGenerated|TestAccApiGatewayApiIamMemberGenerated|TestAccApiGatewayApiIamBindingGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample|TestAccApiGatewayApiConfig_apigatewayApiConfigFullExample|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample|TestAccApiGatewayGateway_apigatewayGatewayFullExample|TestAccApiGatewayGateway_apigatewayGatewayBasicExample|TestAccServiceDirectoryServiceIamPolicyGenerated|TestAccServiceDirectoryNamespaceIamMemberGenerated|TestAccServiceDirectoryNamespaceIamBindingGenerated|TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated|TestAccServiceDirectoryServiceIamMemberGenerated|TestAccServiceDirectoryServiceIamBindingGenerated|TestAccServiceDirectoryNamespaceIamPolicyGenerated|TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccApiGatewayApi_apigatewayApiFullExample|TestAccApiGatewayApi_apigatewayApiBasicExample|TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccDataprocMetastoreFederationIamMemberGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated|TestAccDataprocMetastoreFederationIamBindingGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated

[modular-magician]

Tests passed during RECORDING mode: TestAccBigqueryDatapolicyDataPolicyIamMemberGenerated[Debug log] TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log] TestAccApiGatewayGatewayIamMemberGenerated[Debug log] TestAccApiGatewayGatewayIamPolicyGenerated[Debug log] TestAccApiGatewayGatewayIamBindingGenerated[Debug log] TestAccApiGatewayApiIamPolicyGenerated[Debug log] TestAccApiGatewayApiIamMemberGenerated[Debug log] TestAccApiGatewayApiIamBindingGenerated[Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigFullExample[Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExample[Debug log] TestAccApiGatewayGateway_apigatewayGatewayFullExample[Debug log] TestAccApiGatewayGateway_apigatewayGatewayBasicExample[Debug log] TestAccApiGatewayApi_apigatewayApiBasicExampleUpdated[Debug log] TestAccRuntimeConfigConfigIamPolicyGenerated[Debug log] TestAccApiGatewayApi_apigatewayApiFullExample[Debug log] TestAccApiGatewayApi_apigatewayApiBasicExample[Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigBasicExampleUpdated[Debug log] TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated[Debug log]

Tests failed during RECORDING mode: TestAccComputeMachineImageIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccComputeMachineImageIamPolicyGenerated[Error message] [Debug log] TestAccComputeMachineImageIamBindingGenerated[Error message] [Debug log] TestAccComputeMachineImageIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeMachineImageIamMemberGenerated[Error message] [Debug log] TestAccComputeMachineImageIamMemberGenerated_withCondition[Error message] [Debug log] TestAccApiGatewayApiConfigIamPolicyGenerated[Error message] [Debug log] TestAccApiGatewayApiConfigIamMemberGenerated[Error message] [Debug log] TestAccApiGatewayApiConfigIamBindingGenerated[Error message] [Debug log] TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample[Error message] [Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample[Error message] [Debug log] TestAccServiceDirectoryServiceIamPolicyGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamMemberGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamBindingGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamMemberGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamBindingGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamPolicyGenerated[Error message] [Debug log] TestAccDataprocMetastoreFederationIamPolicyGenerated[Error message] [Debug log] TestAccDataprocMetastoreFederationIamMemberGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamMemberGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamPolicyGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamMemberGenerated[Error message] [Debug log] TestAccDataprocMetastoreFederationIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamPolicyGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamBindingGenerated[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

[SarahFrench]

At least the code builds now!

[SarahFrench]

Service directory IAM acceptance tests are a pain to update - around use of name that takes a value of the full ID of the resource and then correctly templating the URL for the resource using that.

Have issues with URL that repeats like project/x/location/x/namespace/x/service/project/x/location/x/namespace/x/service/x

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 16 insertions(+), 20 deletions(-)) Terraform Beta: Diff ( 22 files changed, 462 insertions(+), 71 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 16 insertions(+), 16 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0 Passed tests 0 Skipped tests: 0 Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 20 insertions(+), 20 deletions(-)) Terraform Beta: Diff ( 22 files changed, 466 insertions(+), 71 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 8 files changed, 16 insertions(+), 16 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2427 Passed tests 2147 Skipped tests: 254 Failed tests: 26

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccServiceDirectoryNamespaceIamPolicyGenerated|TestAccServiceDirectoryServiceIamPolicyGenerated|TestAccServiceDirectoryServiceIamBindingGenerated|TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccDataprocMetastoreFederationIamMemberGenerated|TestAccDataprocMetastoreFederationIamBindingGenerated|TestAccServiceDirectoryNamespaceIamBindingGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccComputeMachineImageIamBindingGenerated|TestAccComputeMachineImageIamBindingGenerated_withCondition|TestAccComputeMachineImageIamMemberGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated|TestAccComputeMachineImageIamMemberGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccServiceDirectoryServiceIamMemberGenerated|TestAccServiceDirectoryNamespaceIamMemberGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamBindingGenerated

[modular-magician]

Tests failed during RECORDING mode: TestAccServiceDirectoryNamespaceIamPolicyGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamPolicyGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamBindingGenerated[Error message] [Debug log] TestAccDataprocMetastoreFederationIamPolicyGenerated[Error message] [Debug log] TestAccDataprocMetastoreFederationIamMemberGenerated[Error message] [Debug log] TestAccDataprocMetastoreFederationIamBindingGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamPolicyGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamMemberGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamMemberGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamPolicyGenerated[Error message] [Debug log] TestAccComputeMachineImageIamBindingGenerated[Error message] [Debug log] TestAccComputeMachineImageIamBindingGenerated_withCondition[Error message] [Debug log] TestAccComputeMachineImageIamMemberGenerated_withCondition[Error message] [Debug log] TestAccComputeMachineImageIamPolicyGenerated[Error message] [Debug log] TestAccComputeMachineImageIamMemberGenerated[Error message] [Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample[Error message] [Debug log] TestAccComputeMachineImageIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccDataCatalogTaxonomyIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamBindingGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamMemberGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamMemberGenerated[Error message] [Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample[Error message] [Debug log] TestAccApiGatewayApiConfigIamPolicyGenerated[Error message] [Debug log] TestAccApiGatewayApiConfigIamMemberGenerated[Error message] [Debug log] TestAccApiGatewayApiConfigIamBindingGenerated[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 28 insertions(+), 28 deletions(-)) Terraform Beta: Diff ( 26 files changed, 512 insertions(+), 117 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 12 files changed, 24 insertions(+), 24 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2429 Passed tests 2145 Skipped tests: 254 Failed tests: 30

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccComputeMachineImageIamMemberGenerated_withCondition|TestAccComputeMachineImageIamBindingGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated|TestAccComputeMachineImageIamMemberGenerated|TestAccComputeMachineImageIamBindingGenerated|TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample|TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccComputeMachineImage_machineImageBasicExample|TestAccComputeMachineImage_computeMachineImageKmsExample|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample|TestAccServiceDirectoryNamespaceIamPolicyGenerated|TestAccServiceDirectoryServiceIamPolicyGenerated|TestAccServiceDirectoryServiceIamMemberGenerated|TestAccDataprocMetastoreFederationIamMemberGenerated|TestAccDataprocMetastoreFederationIamPolicyGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataprocMetastoreFederationIamBindingGenerated|TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample|TestAccServiceDirectoryNamespaceIamMemberGenerated|TestAccServiceDirectoryServiceIamBindingGenerated|TestAccServiceDirectoryNamespaceIamBindingGenerated

[modular-magician]

Tests passed during RECORDING mode: TestAccComputeMachineImageIamPolicyGenerated_withCondition[Debug log] TestAccComputeMachineImageIamMemberGenerated_withCondition[Debug log] TestAccComputeMachineImageIamBindingGenerated_withCondition[Debug log] TestAccComputeMachineImageIamPolicyGenerated[Debug log] TestAccComputeMachineImageIamMemberGenerated[Debug log] TestAccComputeMachineImageIamBindingGenerated[Debug log] TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBigqueryExample[Debug log] TestAccDataprocMetastoreFederation_dataprocMetastoreFederationBasicExample[Debug log] TestAccComputeMachineImage_machineImageBasicExample[Debug log] TestAccComputeMachineImage_computeMachineImageKmsExample[Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcFullExample[Debug log] TestAccDataprocMetastoreFederationIamMemberGenerated[Debug log] TestAccDataprocMetastoreFederationIamPolicyGenerated[Debug log] TestAccDataprocMetastoreFederationIamBindingGenerated[Debug log] TestAccApiGatewayApiConfig_apigatewayApiConfigGrpcExample[Debug log]

Tests failed during RECORDING mode: TestAccDataCatalogPolicyTagIamPolicyGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamMemberGenerated[Error message] [Debug log] TestAccApiGatewayApiConfigIamPolicyGenerated[Error message] [Debug log] TestAccApiGatewayApiConfigIamMemberGenerated[Error message] [Debug log] TestAccApiGatewayApiConfigIamBindingGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamPolicyGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamPolicyGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamMemberGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamPolicyGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamMemberGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamMemberGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamBindingGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamBindingGenerated[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 28 insertions(+), 28 deletions(-)) Terraform Beta: Diff ( 26 files changed, 512 insertions(+), 117 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 12 files changed, 24 insertions(+), 24 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2430 Passed tests 2160 Skipped tests: 254 Failed tests: 16

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_failedCreation|TestAccServiceDirectoryNamespaceIamPolicyGenerated|TestAccServiceDirectoryNamespaceIamMemberGenerated|TestAccServiceDirectoryNamespaceIamBindingGenerated|TestAccServiceDirectoryServiceIamPolicyGenerated|TestAccServiceDirectoryServiceIamMemberGenerated|TestAccServiceDirectoryServiceIamBindingGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccApiGatewayApiConfigIamMemberGenerated|TestAccApiGatewayApiConfigIamBindingGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated

[modular-magician]

Tests passed during RECORDING mode: TestAccContainerCluster_failedCreation[Debug log] TestAccApiGatewayApiConfigIamMemberGenerated[Debug log] TestAccApiGatewayApiConfigIamBindingGenerated[Debug log] TestAccApiGatewayApiConfigIamPolicyGenerated[Debug log]

Tests failed during RECORDING mode: TestAccServiceDirectoryNamespaceIamPolicyGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamMemberGenerated[Error message] [Debug log] TestAccServiceDirectoryNamespaceIamBindingGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamPolicyGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamMemberGenerated[Error message] [Debug log] TestAccServiceDirectoryServiceIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamPolicyGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogTaxonomyIamMemberGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamPolicyGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamBindingGenerated[Error message] [Debug log] TestAccDataCatalogPolicyTagIamMemberGenerated[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

[SarahFrench]

Import of DataCatalogTaxonomy resources is blocked, because the ID of the resource isn't determined by the config made by users. This is also the case for DataCatalogPolicyTag acceptance tests, because the parent resource used by those tests has the same identification issue.

In the example below you set display_name but it is just a display name.

resource "google_data_catalog_taxonomy" "basic_taxonomy" {
  provider = google-beta
  region = "us"
  display_name =  "tf_test_my_display_name"
  description = "A collection of policy tags"
  activated_policy_types = ["FINE_GRAINED_ACCESS_CONTROL"]
}

Given the HCL above, instead of having a name like this:

projects/PROJECT_ID/locations/us/taxonomies/tf_test_my_display_name

instead it's like this:

projects/PROJECT_ID/locations/us/taxonomies/12345678910

Where the number is returned from the API. Because of this, we would need to get data out of the test to configure the next test step that tests imports, and currently this isn't possible

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 31 insertions(+), 28 deletions(-)) Terraform Beta: Diff ( 27 files changed, 515 insertions(+), 117 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 12 files changed, 24 insertions(+), 24 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2430 Passed tests 2161 Skipped tests: 254 Failed tests: 15

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccContainerCluster_failedCreation|TestAccServiceDirectoryNamespaceIamBindingGenerated|TestAccServiceDirectoryServiceIamPolicyGenerated|TestAccServiceDirectoryServiceIamMemberGenerated|TestAccServiceDirectoryServiceIamBindingGenerated|TestAccServiceDirectoryNamespaceIamMemberGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataCatalogTaxonomyIamMemberGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccDataCatalogTaxonomyIamBindingGenerated|TestAccDataCatalogPolicyTagIamBindingGenerated|TestAccServiceDirectoryNamespaceIamPolicyGenerated|TestAccDataCatalogPolicyTagIamMemberGenerated|TestAccFirebaserulesRelease_BasicRelease