ethereum
Lints to ensure link text for EIPs should match the EIP's number
Pushed updates. I tried to fix everything according to comments. Haven't found EIP-1 example in existing eips. So, for now ignoring you)) Can we create a new issue for it in case it comes later?
Hardcoded regexes in lib.rs are kind of a style for the whole file, I followed the pattern. If we need to change regexes in config files, we need to refactor it globally.
Hardcoded regexes in lib.rs are kind of a style for the whole file, I followed the pattern. If we need to change regexes in config files, we need to refactor it globally.
The configuration in lib.rs (default_lints_enum is just the defaults. Hard coding there is fine because anything there can be overridden by the config file.
Other regexes, like this one cannot be overridden.
I've added a test in https://github.com/ethereum/eipw/pull/99/commits/09d7de74228d6daffc408655b6bf7b479eb5e8c6 that demonstrates the problem I brought up in https://github.com/ethereum/eipw/pull/99#discussion_r1664272030.
Hardcoded regexes in lib.rs are kind of a style for the whole file, I followed the pattern. If we need to change regexes in config files, we need to refactor it globally.
The configuration in
lib.rs(default_lints_enumis just the defaults. Hard coding there is fine because anything there can be overridden by the config file.Other regexes, like this one cannot be overridden.
This one is dynamic. It depends on the lib.rs pattern. I extract the number of eip there and put into a new regex. Do you have any better ideas?
@SamWilsn, I've done with the fixes. Could you please review it and merge if there are no any comments?
@SamWilsn I updated Rust (1.80.1 the latest stable version) and now have this issue with time crates https://github.com/rust-lang/rust/issues/127343. Can't build the project anymore. Can we somehow fix it? Delete it from Cargo.lock? I haven't found it elsewhere in the project.
If you're using rustup, you can use, for example, cargo +1.69 build to pick a particular version.
I'll update the rust version in a separate PR.