Sam Mousa
Sam Mousa
It feels like the annotations in the `ReflectionClass.stub` file are ignored. ```php /** * @return false */ public function isEnum(): bool { } ``` ``` Failed assertions in /projects/phpstan-src/tests/PHPStan/Analyser/nsrt/reflectionclass-isEnum.php: Line...
It is wrong 100%, but my objective here was to test if the annotation is working at all. The simplest annotation I could think of was `@return false`.... And if...
> Do not forget to also update ReflectionClassWithLazyObjects.stub. That was the cause, I did not realize there are 2 stubs for this class. Thanks, now I can get to work...
Current implementation works! I'd like to actually narrow the class (template type `T`) of the reflection object as well, but that doesn't seem to work yet.
Parse_url does not support relative urls. > Caution This function may not give correct results for relative or invalid URLs, and the results may not even match common behavior of...
Yes, just get phpstan. For example using phive.
Don't force push please. It makes reviewing harder!
> I'm not quite sure how a relative URL would apply to the use cases of the `\Codeception\Util\Uri` metods? From the webdriver module: ```php private function filterNodesByHref(string $url, array $nodes):...
It is private for a good reason. It should not be public. If it is public any part of your code could change it and therefore make it inconsistent with...
Okay, so several things to note: - symfony mailer supports load balancing by defaul, check its docs on how to configure - you could (should?) implement a load balancing transport...