Sam Mousa
Sam Mousa
- [x] Trusted contributor - [x] Changes look reasonable - [x] Tests pass I'd say just merge this!
@TavoNiievez what's your confidence level on this? Can I go ahead and merge this or do you feel there's specific things that need an extra good look?
I'm gonna defer to him, and gonna ping him hoping he'll give the okay then! @Naktibalda you up for reviewing this?
Hmm seems to be the case indeed. They have another closed issue for react native which has similar problem. There was another implementation of this functionality somewhere, but i can't...
Thanks for pushing this over the finish line. It fell off of my list of priorities.
We could try and get them to build for esm too? It shouldn't be too complex. See https://github.com/bundled-es-modules/tough-cookie/ It's been a while since I looked, I remember considering implementing the...
Regardless of the issue here; there's always the possibility for a race condition where you remove all files but before you can remove the directory another process adds a new...
@qrazi I'm reopening this issue for the next major release. I've looked at the craft implementation of the subclass and I'm wondering if the same could not be achieved via...
@qrazi, just a heads up i'm releasing v2; this will reintroduce this issue for you. I'm doing this because finalizing is a major release and we could always unfinalize it...
> So, is this a case where Codeception Modules decide for themselves how they can be extended? So, I / someone should make PR for the documentation on Codeception? I...