Sam Mousa

Results 439 comments of Sam Mousa

Closing this, create a new issue if you need help / guidance on using composition to offer your own functionality in the module.

> Can you please add some clear documentation linked to the readme section with few real-world examples to explain this composition method. What do you mean? There's plenty of articles...

1. `__sleep()` is deprecated. https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup 2. I don't think you should be extending framework classes, it is an anti-pattern 3. If you really need to serialize your dependent class I'd...

What about moving to pure CSS? Simplifies the build and this library is so small that it should suffice.

I'm working on a PR that moves to esbuild. It'll move us to vanilla css too

Could / should we not use `Descriptor::getTestSignatureUnique`? ```php /** * Provides a test name which is unique for individual iterations of tests using examples */ public static function getTestSignatureUnique(SelfDescribing $testCase):...

My preferred solution is to not implement an extensions API at all, it feels like a bit of overkill. Furthermore the extensions API will effectively make most of the inner...

@terrafrost please have a look at #2029. It is not what you preferred but I hope you can see the benefits of this simplicity.

I don't really care about implementing all extensions, my point was more that there are so few of them widely used that setting up an extension system is overkill. If...