Sam Mousa

Results 439 comments of Sam Mousa

According to the puny code userland implementation, you only need to change the import: ![image](https://github.com/garycourt/uri-js/assets/547021/90b901bb-a24e-433f-8550-a2ca54f1042d) Also as soon as the module is actually removed it'll automatically resolve the userland module......

I'm ready to push the PR, what branch should I target?

I don't like doing composer install inside docker. You need the uid config etc and it's a hassle. It's reasonable to assume contributors have composer installed. I do like the...

> I am not sure if I can mount source DIR as RO, as composer does need to write to it(remember composer.lock file) We should get it to write the...

https://github.com/yiisoft/yii2/blob/master/framework/test/BaseActiveFixture.php#L45 That one is wrong too then.

@Mikk36 i'm open to a PR that relaxes it to baseactiverecord.

I think the record helpers will already work. The mongo AR model extends BaseActiveRecord, which implements `ActiveRecordInterface`. So we can have the helpers use that as a typehint. For transactions...

That's just SQL part though; I think that part works already?