S3RK

ConceptACK. Separating this responsibility from `CWallet` class is reducing complexity and introduces useful abstractions. @furszy I noticed that you left original methods to deal with address book in `CWallet`. Some...

@achow101 why do you think no callers should have access to `AddressBookMan`? I agree that having proxy functions doesn't help with maintainability, but I'd just say we need to drop...

Concept NACK. Using shell redirection is enough for CLI. Probably this change is better fitting with the GUI.

Simulation results here https://github.com/S3RK/coin-selection-simulation/tree/25647-sim/results/25647

Added one commit c8cf08ea743e430c2bf3fe46439594257b0937e5 and rebased on master again

> > It is not possible to remove a provider. > > Maybe a better solution would be a way to disable using a provider? It's possible to deactivate a...

Changeless txs are already somewhat prioritised since creating and spending a change increases waste metric. When you force a solution without change you forego a more economically efficient solution. The...

> So something like the `maxapsfee`? Not sure what `maxapsfee` means, but I was thinking about a config parameter that would decrease waste metric for changeless solutions by the specified...

As far as I remember the keys are for `postgres` user which is used by barman https://github.com/paunin/PostDock/blob/982fbd1af1e80be2107a8d46c3f5a530cc392dc9/src/ssh/entrypoint.sh#L5 https://github.com/paunin/PostDock/blob/982fbd1af1e80be2107a8d46c3f5a530cc392dc9/src/barman/configs/barman.conf#L2 Did you change the user for barman?

Can you elaborate on "support different actual wallet classes (in particular, core-lighting wallets)"? I always though of lighting wallets operating on another abstraction layer on-top of bitcoin wallets, i.e. bitcoin...