S3RK
S3RK
> The downside of this is approach is that I had to sprinkle `const bool can_grind_r = !wallet->IsWalletFlagSet(WALLET_FLAG_EXTERNAL_SIGNER);` in several different places. @furszy's commit does it in three places. This...
ACK 807de2cebdad960c2b52185528ca8960ec694f49 Thanks your patience and addressing the feedback.
The description now says the PR depends on itself :-)
Do we want to align the implementation with Electrum? https://github.com/spesmilo/electrum/issues/8073 I'm not sure if that could be a source of further fingerprinting
Approach ACK. Doing a proper code review now. Have a question about the upgrade. What do you think we should do in the following situation? - Create a blank wallet...
Code review ACK c79539fc20d902b5f9e098cc996c4e27c8e5b8c5 I plan to test this manually a bit later
tACK c79539fc20d902b5f9e098cc996c4e27c8e5b8c5 I found one odd behaviour mentioned in https://github.com/bitcoin/bitcoin/pull/26728#issuecomment-1489825161 Even if you create a wallet with the master branch you still have one opportunity to trigger upgrade procedure Reproduction...
reACK 24b3ee7ee9b4fd1fb6f07bb03676379b5e58d3ad Two new commits added since last review to ensure `WALLET_FLAG_GLOBAL_HD_KEY` is set for all new and migrated descriptor wallets.
reACK 14e2b74332bfdf455ed80ae2487762b24596235d Now `WALLET_FLAG_GLOBAL_HD_KEY` is set for all descriptors wallets, including watch only
> I'm not seeing any reason for keeping the HD keys in memory. Their only use case is the RPC `getxpub` command. Which shouldn't be frequent at all, and could...