S3RK

Results 67 comments of S3RK

utACK 1cfed6ce6cd8c9f9f1e93662ff8f92cd5a5b91c4 (also reviewed the tests)

ReACK 6a302d4 Thanks for addressing feedback

Concept ACK. But approach wise I'd like us to preserve the intent of the user that the wallet is intended as `manual` (we should pick a better term). Would it...

As far as I understand after this PR is merged we will start unsetting the blank flag and loosing the users' intent. Are we okay with loosing the intent for...

Code review ACK c5fb9a4dd97b47db0e52c497a757dff943b255b1 I'm still slightly hesitating though. One question that still bothers me is whether we should expose `blank` flag at all. It's an implementation detail and we...

re code review ACK 7baa0971527ba3c8d87b82c7a2a4eabf6abbb2b7 My previous comment about exposing `blank` flag is still valid, but I don't think it's blocking. I like furszy's suggestion to return the flag only...

reACK cdba23db353a1beff831ff4fc83d01ed64e8c2a9 Appreciate the perseverance in addressing all the comments and arriving at consensus. Thank for working on this.

> I'm also wondering if the earlier discussion about adding a "manual" flag ([#25634 (comment)](https://github.com/bitcoin/bitcoin/pull/25634#issuecomment-1476485625)) is still relevant. Is the blank flag already acting like manual flag for descriptor wallets...

Code review ACK 0295b44c257fe23f1ad344aff11372d67864f0db Still not a huge fan of 596642c5a9 and I have same concerns as josibake. I prefer explicit defitino of external inputs rather than indirectly through `SetTxOut`....

I have a question related to `sethdseed`. I can see why we would want to be able to _set_ a seed for an empty wallet, this is use case is...