S3RK

Results 67 comments of S3RK

> I think this is a good change for a different reason than the one stated. Even if there won't be multiple wallet implementations, letting RPC methods interact with wallets...

@aureleoules can we achieve the same result by using descriptors wallet with only segwit descriptors?

> But if I understand correctly, this feature might still be useful in cases where you don't control the wallet. @aureleoules Do you have a concrete use-case in mind? I'm...

> > Do you have a concrete use-case in mind? I'm not sure, but it seems #25181 supposes that we do control the wallet. > > I believe if your...

Concept ACK. This PR is a clearly an improvement from users' perspective. Approach wise, I don't like that `CCoinControl` is becoming bloated collection of loosely related parameters. We already have...

Thinking about this I've got a question: Do we even need to store a flag for a blank wallet? Can't we just check whether it has any descriptors in it...

Code review ACK 0bb90cabc8e2c6bbbc3c52ec1170e725435b625d modulo tests. I believe this PR is a good improvement over status quo. The biggest worry I have now it somewhat ambiguous terminology: - `mixed` groups...