Ryan Foster

Results 601 comments of Ryan Foster

Technically not fixed until we actually update the deps here.

> Using the BtbN builds `n6.1.1-1-g61b88b4dda-20240206` as suggested on FFmpeg website OBS Studio 30.0.2 uses FFmpeg n6.0 with some commits backported. Please test with that to see if `-hwaccel d3d11va`...

I dug into this a little bit. The short answer so far is that `avcodec_get_hw_config` returns null if the media codec is AV1. Checking the debug log output of ffmpeg.exe,...

> I think your suspicions are probably right. The example implementation hasn't been touched seriously in over 3 years. It's probably safe to say nobody tested against it. The tricky...

While I appreciate the enthusiasm and the attempt to get visibility on this, our repo is probably not the best place to discuss issues with FFmpeg examples. For issues with...

> I cannot change the commit message anymore (without force pushing anyway). Force pushing to fix commit messages is fine. > Could someone just check if this works and put...

> Obviously OBS can't do anything about the fact that HQVBR requires preanalysis and that only works with NV12, but it sure can provide a more meaningful error > As...

> Can you not check for `EnablePreAnalysis=true` directly? Technically you should be able to enable it with other rate control methods manually too, right? I'm not sure the property itself...

I might remove the backticks from the commit message though.