Ryan Foster

Results 601 comments of Ryan Foster

> Overall I'm fine with this change, though it obviously touches a whole lot casts in the code that touch a whole lot of aspects of our frontend code, so...

Is this failing anywhere in OBS itself, or is this only failing with third-party code that calls this? Can third-party code work around this failure?

@style1925 Can you also confirm that your test case still works?

As this fix is not yet finalized, I am inclined to merge the revert (#12422) to unbreak SDR (likely the more common use-case) until this can be fixed.

Will probably target this for 32.1.

Do not use merge commits to keep up with master branch history. Use `git rebase` instead.

> I use the regular ffmpeg-6.1.1 package. This wasn't what @derrod asked. Are you building with _our_ legacy CMake? That is, are you building without using the `ubuntu` preset or...

@GeorgesStavracas Thoughts on this approach?

Personally I'd probable prefer to call it `obs-deps-buildstream` (if "BuildStream" is more or less exclusively associated with Flatpak that makes it superfluous to mention it in the repo name) I'd...