Ryan Foster

Results 601 comments of Ryan Foster

I'll pick this up again early next week.

Building on Windows 11 in RelWithDebInfo or Debug resulted in a failure to launch: ![image](https://github.com/obsproject/obs-studio/assets/624931/2d050112-1762-46bd-992a-dccce3ab460a) ``` --------------------------- obs64.exe - System Error --------------------------- The code execution cannot proceed because libx264-164.dll was...

Confirming that I can now build and run in Debug, RelWithDebInfo, and Release on Windows 11. cmake-format is still failing on `cmake/finders/FindLibx264.cmake` though, so that will need to be fixed.

@PatTheMav and I did some off-thread testing and debugging and found a few lingering items to fix up. Will re-check this "soon".

> The clang format stuff is failing even though I ran clang-format with: `git filter-branch --tree-filter 'git-clang-format; true' -- c71bbcf4d99039579e2c6996d55db691fb17a05c..HEAD` which changed the formatting and seems to have worked. >...

> 16.0.5 was never packaged for Arch, only 16.0.6. Is there some container I should be using? You'll have to ask someone (or wait for someone) familiar with development on...

The Apple sample app does the same thing as OBS here, so this seems like intended behavior for ScreenCaptureKit. Closing as such.

> FFmpeg has not released a newer version yet, so remuxing to MP4 with PCM will still fail. Remuxing to MOV should work though. Was it FFmpeg 6.1 that was...

It's perhaps important to note that this is a resubmission of #7798. For those reviewing, please read comments there.

It looks like some unrelated changes were pulled in during a rebase attempt.