Ryan Foster

Results 601 comments of Ryan Foster

You do not need to pull in commits that are unnecessary to this PR's scope into this PR. It just creates more notifications for those subscribed. I don't think that...

Looks fine at a glance to me. If @notr1ch and @PatTheMav think the implementation is good enough for now and further improvements/changes can be done later, then we just need...

Successfully built and tested on Ubuntu 22.04 running Xorg. What's New dialog pops up successfully. There seems to be a _short_ UI hang for 1-2 seconds.

I can confirm this on Windows 10 with OBS Studio 28.0.0-beta1.

We can confirm that this has been fixed in OBS Studio 28.0.0 Beta 2 by https://github.com/obsproject/obs-studio/commit/86963f65d2b83de0616e16b87332dd1f1672387d. The issue seems to have been related to https://github.com/obsproject/obs-studio/commit/69ff026647b8f3e9a3183eec760e9047ba667520 (#5218).

Could you give text dumps of the metadata instead? Comparing images of text is not ideal.

I think this is premature. We still have to get 32-bit components for win-capture and win-dshow building as 32-bit targets to ensure they can still compile before completely axing 32-bit...

Here's how this PR currently looks on my laptop screen, which uses a 125% custom scaling factor. ![image](https://user-images.githubusercontent.com/624931/186530112-521d5bf1-72b5-49a7-924b-7799ce220782.png)

What was the purpose of this change after an approval was given? It looks like some stylistic preference rather than a functional change, so it _shouldn't affect anything, unless there's...