Ryan

Results 632 comments of Ryan

Asks from Tridge: * We want it used in Github * We need to ensure the code formatter doesn't cause parsing parameters * We should use git-blame-ignore-revs to preserve history...

> * We don't expect people to format partial files > [ ] that could cause issue on start as precommit will try to fix modified files as people are...

> * We need a way to ignore it > [ X ] We just need to document it, it is easy to disable and force no check on cmdline,...

> Just go with whatever VSCode does. I use CLI, but I think most IDE people are using VSCode. There is nothing built in to the default vscode that handles...

Removing `plt.ion()` and adding a call to `plt.show()` resolves this. If you have any tips for why `plt.ion` is defaulted on, please share.

This will affect non-ROS2 users also. The default developer dockerfile has the same problem because ArduPilot has users run it as root.

@khancyr I'd love your input. Do we want ArduPilot devs using docker as root, and make ardupilot scripts capable of running in root, or do we want to add stuff...

> Wouldn't a user ordinarily be in the ArduPilot venv here? It seems you're creating a new venv as part of these instructions... These instructions are for an isolated env....

How are we supposed to install the wsproto dependency of pymavlink? https://github.com/ArduPilot/pymavlink/pull/967/files#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552R10 * ardupilot/ools/scripts/install-prereqs-ubuntu.sh doesn't have it * The setup.py file of pymavlink doesn't have it, only the requirements.txt *...

@peterbarker Can you explain why the ardupilot virtual environment is necessary? The docs don't seem to agree. Here's why: The ardupilot setup is explained as the setup for building the...