Ryan

Results 632 comments of Ryan

> > > Also, `pexpect` is not declared as a dependency in the package.xml files currently. I'm guessing this is a package that is common on some Ubuntu distributions but...

Wiki PR for the time being: https://github.com/ArduPilot/ardupilot_wiki/pull/5943 My brother missed this one on setup and I broke some props. It's not intuitive (yet).

I have a branch that is close to fixing this: `28497-fix-waf-dds-gen-race`

No, if you can figure it out on the branch I had started, that would be great. I was pretty close.

Tangentionally related to * https://github.com/PX4/PX4-Autopilot/pull/23854 * https://github.com/PX4/PX4-Autopilot/pull/23744 * https://github.com/ArduPilot/ardupilot/pull/20979 * https://github.com/ArduPilot/ardupilot/pull/23942 * https://github.com/ArduPilot/ardupilot/issues/5672 * https://github.com/mavlink/mavlink/issues/1829

MAVROS handles it here: https://github.com/mavlink/mavros/blob/b49095727a6ff160e1e913b90a4ce50e383e8863/mavros/src/plugins/global_position.cpp#L289C71-L289C96 It hard codes the geoid to EGM-96: https://github.com/mavlink/mavros/blob/b49095727a6ff160e1e913b90a4ce50e383e8863/mavros/include/mavros/mavros_uas.hpp#L163

Would you be open to adding a maintainer? I could maintain it on behalf of AV. Is there a reason it won't be released? We're using it as-is on humble...

https://discourse.ros.org/t/osrf-dynamic-message-introspection-maintainer-binary-release/42149

Looks theres' some conflicts with `Tools/gittools/pre-commit.py` which overwrites pre-commit. ``` (venv-ardupilot) ryan@ryan-B650-970:~/Development/ardu_ws/src/ardupilot$ pre-commit install Running in migration mode with existing hooks at .git/hooks/pre-commit.legacy Use -f to use only pre-commit. pre-commit...

Would be nice to run astyle in CI too to prevent errors like these: https://github.com/ArduPilot/ardupilot/pull/24792#discussion_r1307250568