Russ Tedrake
Russ Tedrake
The CI failure in hardware_station is clearly and unrelated flake. Squashing now.
You're right. I should have chosen my words more carefully. I just need to have each different license vetted by the reviewers as those models are accepted into the drake...
> One test is failing because of linting issues. How do you typically go about debugging this? You should be running the tests locally. `bazel test //...`. If you want...
*[`geometry/optimization/graph_of_convex_sets.h` line 594 at r2](https://reviewable.io/reviews/RobotLocomotion/drake/21530#-O-Ceg5a3gEuDRl1pCgT:-O0sfrLN87aB6L3u0TyG:b-6lv3vx) ([raw file](https://github.com/RobotLocomotion/drake/blob/393d8505e82c5879a6ddfce6b1c543061de1b193/geometry/optimization/graph_of_convex_sets.h#L594)):* Previously, RussTedrake (Russ Tedrake) wrote… Ah. This is now a breaking change. Technically GCS is still marked as experimental, so we _can_ make...
*[`bindings/pydrake/geometry/test/optimization_test.py` line 819 at r3](https://reviewable.io/reviews/RobotLocomotion/drake/21530#-O0sgWAc94TJnbQxULl0:-O0sgWAc94TJnbQxULl1:b-qk2uc) ([raw file](https://github.com/RobotLocomotion/drake/blob/38c8f1d6521c7323e259ae902076aec9dc255fec/bindings/pydrake/geometry/test/optimization_test.py#L819)):* > ```Python > "source", > spp.GetGraphvizString( > result=result, options=graphviz_options, active_path=[edge0] > ``` actually there is a way to accept the struct fields as...
*[`bindings/pydrake/geometry/geometry_py_optimization.cc` line 722 at r3](https://reviewable.io/reviews/RobotLocomotion/drake/21530#-O0siNZB9zFPhMOg7gLz:-O0siNZB9zFPhMOg7gM-:baj59gu) ([raw file](https://github.com/RobotLocomotion/drake/blob/38c8f1d6521c7323e259ae902076aec9dc255fec/bindings/pydrake/geometry/geometry_py_optimization.cc#L722)):* > ```cpp > const auto &cls_doc = doc.GcsGraphvizOptions; > py::class_ gcs_options(m, "GcsGraphvizOptions"); > gcs_options.def(py::init()) > ``` consider the use of ParamInit (e.g. as...
I also like the idea of a single `prepare_model_for_drake.py`. https://github.com/RobotLocomotion/drake/issues/19109#issuecomment-2219287999
Note: I believe that this could become much easier to support once the [in-memory mesh PR train](https://github.com/RobotLocomotion/drake/issues/15263) lands.
*[`multibody/meshcat/joint_sliders.cc` line 242 at r4](https://reviewable.io/reviews/RobotLocomotion/drake/22496#-OHTeT8t0eCte3OJRE8V:-OHjIseMDeI_YxZuDC58:b-dgkhas) ([raw file](https://github.com/RobotLocomotion/drake/blob/4259465972dabed48bcb4ace06b081499d867c51/multibody/meshcat/joint_sliders.cc#L242)):* Previously, jwnimmer-tri (Jeremy Nimmer) wrote… Is it _important_ to remove the old constraint? If sliders' limits are monotonically tighter, it seems like just...
*[`multibody/meshcat/joint_sliders.h` line 150 at r4](https://reviewable.io/reviews/RobotLocomotion/drake/22496#-OHx4a40DEiPMluWWEGX:-OHxDv3b291k4u-wDI3N:b-hucc3s) ([raw file](https://github.com/RobotLocomotion/drake/blob/4259465972dabed48bcb4ace06b081499d867c51/multibody/meshcat/joint_sliders.h#L150)):* Previously, jwnimmer-tri (Jeremy Nimmer) wrote… Actually, why are we deprecating this? Isn't it still useful to be able to tweak the `initial_value` passed...