Roman Bapst

Results 44 comments of Roman Bapst

@julianoes I will try to add an example. Maybe loading a VTOL mission from a plan file and making sure that the distance between planned home and the VTOL takeoff...

@julianoes Thanks for the review, I wasn't actually done with this, just wanted to get it to compile (thanks to @JonasVautherin for helping with that). I can now wrap it...

@julianoes Yes, I would still like to bring this in. I was plagued by compiling issues which turned out to be related to my cmake version, as @JonasVautherin could not...

@KonradRudin @sfuhrer I added the fixed wing check as agreed.

@sfuhrer @bresch Could you guys please approve?

@oravla5 Something that is not so nice about this is that the landing logic also sets the time contstant and it's a separate path that does not use the smoothed...

@oravla5 I agree with @Jaeyoung-Lim on the point that the global state is not ideal. How about if each control_... method decides on the time constant it wants to use...

@bresch @Jaeyoung-Lim Are you guys ok with the PR? If yes, please approve so that we can get it in.

> I agree that having different TECS time constants are useful depending on how close the terrain is. > > However, I am still concerned with how this is implemented...

> I am mainly concerned about implementation details here. I think I am convinced that the use case is valid. What would you think about defining the conditions as a...