Olaoluwa Osuntokun
Olaoluwa Osuntokun
> The only difference between my case and that itest is that I make a sat invoice that I attempt to pay with assets, where the itest makes an asset...
> Bitcoin has this predicate issue (since genesis) and it is necessary to perform a risk analysis about this for every proposed change. This document proposes no changes to Bitcoin....
> NACK, this protocol is one of many that exist for this purpose and should remain outside of any spec for bitcoin. BIPs aren't limited to only specs for Bitcoin...
> Confused about why "blip-tap" isn't included here...? That defines LN extensions to put the stuff committed in UTXOs into channels. No BIPs cover LN/BOLT channels as defined. It's written...
With the way the CLI works right now, if you don't sepcify a group key or asset ID, then it returns all of the first page of roots: https://github.com/lightninglabs/taproot-assets/blob/8ff0ae9650c80c50413afaa2cbe50a2cf9cfaa64/cmd/commands/universe.go#L219-L240
Looks like the native SQL itest are still failing: ``` --- FAIL: TestLightningNetworkDaemon/tranche05/107-of-168/bitcoind/sendpayment_amp_invoice_repeat (19.61s) lnd_amp_test.go:300: Error Trace: /home/runner/work/lnd/lnd/itest/lnd_amp_test.go:300 /home/runner/work/lnd/lnd/lntest/harness.go:386 /home/runner/work/lnd/lnd/itest/lnd_test.go:139 Error: Not equal: expected: 1 actual : 2 Test: TestLightningNetworkDaemon/tranche05/107-of-168/bitcoind/sendpayment_amp_invoice_repeat...
So nearly all the SQL backend itests are failing with the latest push. * ` --- FAIL: TestLightningNetworkDaemon/tranche06/144-of-168/bitcoind/blinded_payment_htlc_re-forward (69.08s)` * ` --- FAIL: TestLightningNetworkDaemon/tranche03/80-of-168/bitcoind/multi_hop_htlc_aggregation/zeroconf=false/committype=SCRIPT_ENFORCED_LEASE (171.03s)` * ``` --- FAIL: TestLightningNetworkDaemon/tranche07/156-of-168/bitcoind/listsweeps...
Looks much better on rerun.
Before merging I want to cover this with a unit test, we have the existing retransmission test, and we can mock the aux sigs to specify a value.