Olaoluwa Osuntokun
Olaoluwa Osuntokun
> So I'll need to take a look into that. But hopefully it's something small (will take a closer look tomorrow). I think what's missing is that we need to...
> We do NOT produce any V1 proofs in this PR (outside of unit tests). Otherwise newly minted or transferred assets would not be recognized by older nodes ("unknown proof...
The current timeout is 3 seconds: https://github.com/lightninglabs/aperture/blob/9fd44c9e8f23fcca37b0111398f7990bbd12ddf7/auth/interface.go#L15-L19
Good eye, the bLIP spec (which'l replace the spec at that link above), has this section on backwards compat: https://github.com/lightning/blips/blob/d2a8c19ec6f49677d942d1c03f3ab0a3362e7b39/blip-0026.md#backwards-compatibility We should make it clearer though, add test vectors, and...
Can be rebased now that the dep PR was merged!
I think compared to other migrations the actually read/write a large amount of keys, this migration should be much faster (at least on `bbolt`), as bucket deletion just mark a...
Relevant context: https://github.com/lightninglabs/aperture/blob/9b85f8bbc629c17bb9c4a8f00db33dcadf68e147/proxy/proxy.go#L158-L161
> And if the no-op goes on chain, it looks and behaves the same way as a normal "add" HTLC? Yes it _should_ behave as a normal add HTLC. Parallel...
> if the remote receives lots of payments and refuses to settle, they can claim them via FC - this can be mitigated via restricting the num of inflight payments....
Unit test failure: ``` /home/runner/work/lnd/lnd/lnwire/serialized_size_test.go:17 Error: Should be true Test: TestSerializedSize Messages: message type DynCommit does not implement SizeableMessage FAIL FAIL github.com/lightningnetwork/lnd/lnwire 297.128s ```