Olaoluwa Osuntokun

Results 793 comments of Olaoluwa Osuntokun

Makes sense. If you're interested in tackling this issue, here's the area you need to swap out a network call for a function call into the `zpay32` library: https://github.com/lightninglabs/faraday/blob/b12a8584070efeb67ce96a98a33de4c802c4ba76/accounting/config.go#L194-L198

> Even if this is expected, I couldn't see any documentation about it? I wouldn't say it's expected, but then again there's no sort of "standardized" documentation for the JSON-RPC...

Thanks for this report! This is also something that should be verified in the context of the BIP, potentially with additional test vectors contributed.

Looking at BIP 174, this section seems relevant: > The transaction in network serialization. The scriptSigs and witnesses for each input must be empty. The transaction must be in the...

This BIP has been assigned number 433! (can update the readme in the PR to reflect assignment)

> It seems that many programs have problems with this. Such as?

> possibly use uints for timestamps instead of TIMESTAMP With the way it works to `sqlc`, if you use `TIMESTAMP`, then it [gets stored as a string in Go formatting...

This ready for review again (review wasn't re-requested in UI)?

Looking at the logs, it looks like the v2 -> v1 downgrade may be failing. But then I _do_ see the new connections established again. How many nodes are you...

So `addnode=` isn't actually a config option. Did you mean `addpeer`? https://github.com/btcsuite/btcd/blob/9ff0780da683ec1fa88ce9b9f2f4fd39d5592221/sample-btcd.conf#L91-L97