release: bump version to v0.18.3 rc2

[Roasbeef]

Staging PR for the creation of v0.18.3 rc2.

This PR includes cherry picks of the following PRs:

• #9002
• #9026
• #9011

We also seek to include:

• https://github.com/lightningnetwork/lnd/pull/9009

PRs on deck for the next rc:

• https://github.com/lightningnetwork/lnd/pull/9022
  • Fixes an issue in CI, which uncovered additional issues related to the SQL backend. May require another PR to resolve everything we've found so far.

Once #9009 has been merged, I'll tack on an extra commit that bumps the version.

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

• llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Roasbeef]

So nearly all the SQL backend itests are failing with the latest push.

• --- FAIL: TestLightningNetworkDaemon/tranche06/144-of-168/bitcoind/blinded_payment_htlc_re-forward (69.08s)
• --- FAIL: TestLightningNetworkDaemon/tranche03/80-of-168/bitcoind/multi_hop_htlc_aggregation/zeroconf=false/committype=SCRIPT_ENFORCED_LEASE (171.03s)

•  --- FAIL: TestLightningNetworkDaemon/tranche07/156-of-168/bitcoind/listsweeps (74.98s)
   harness_miner.go:195: Mined 7 blocks while waiting for force closed channel to be resolved
   harness.go:442: finished test: stateless_init, start height=586, end height=586, mined blocks=0
   lnd_onchain_test.go:883: 
       	Error Trace:	/home/runner/work/lnd/lnd/itest/lnd_onchain_test.go:883
       	            				/home/runner/work/lnd/lnd/lntest/harness.go:386
       	            				/home/runner/work/lnd/lnd/itest/lnd_test.go:139
       	Error:      	"[9d664884bb1e2edcb61f6d8c55baed65ebb8aa96fd2f47557bc7259faf839d5e a484a7f5366e7e5a933a837b3ddb2b6fa993337ca817655a181c6e7467baa25b]" should have 3 item(s), but has 2
       	Test:       	TestLightningNetworkDaemon/tranche07/156-of-168/bitcoind/listsweeps
       	Messages:   	number of sweeps, starting from height 0
   harness.go:442: finished test: listsweeps, start height=601, end height=644, mined blocks=43
   harness.go:448: test failed, skipped cleanup
  

•   lnd_route_blinding_test.go:1463: 
        	Error Trace:	/home/runner/work/lnd/lnd/itest/lnd_route_blinding_test.go:1463
        	            				/opt/hostedtoolcache/go/1.22.5/x64/src/runtime/asm_amd64.s:1695
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestLightningNetworkDaemon/tranche06/144-of-168/bitcoind/blinded_payment_htlc_re-forward
    harness.go:442: finished test: blinded_payment_htlc_re-forward, start height=1267, end height=1289, mined blocks=22
    harness.go:448: test failed, skipped cleanup
  

Re-running failures to gauge if anything introduced in this PR is an issue, or if these are flakes.

[Roasbeef]

Looks much better on rerun.