Olaoluwa Osuntokun
Olaoluwa Osuntokun
Hi @Abdulkbk you're correct that in order to make this efficient for transactions, we'd need to modify `GetTransaction` in btcwallet. Right now it's based solely on start and end height,...
So you can use the database interface used in btcwallet to obtain a database cursor.
You can't actually reduce the fee rate due to RBF rules. When you propose an RBF update, it's just for your version of the closing txn. Now with the RBF...
If you're doing RBF, then it's possible that the transaction that we sign ourselves, isn't the one that ultimately gets confirmed.
https://github.com/lightninglabs/taproot-assets/pull/1059 will fix the last two bullet points here
Fixed by https://github.com/lightninglabs/taproot-assets/pull/1059
Great idea! We definitely have some visibility/accounting gaps to fill.
Looks like your transaction has confirmed since the issue was created: https://mempool.space/testnet/tx/c790c31303cccbd4b658ca69c255c824f91bd0c4e9964507d0df003193ea9489 Do you see the receive flow advance now?
> I think we can remove the TODO, since only the root assets need to have an inclusion proof, since the split outputs themselves should be covered by the split...
Is this PR ready to leave draft? We should start to run CI against it.