Ramon Wijnands
Ramon Wijnands
@fgarciacardenas what do you think of this change?
https://github.com/ros2/rosidl_python/pull/140 changed the build to use FindPython3.cmake for building the python modules. This broke our packages that have `-Wl,--no-undefined`. I'm not 100% sure but reading https://gitlab.kitware.com/cmake/cmake/-/issues/18100 it seems that python...
In my own packages I've solved this issue by putting the `-Wl,--no-undefined` after the messages have been generated. Then I can still check if my own code has any missing...
I think the best way is using a `visibility_control.hpp` file in combination with `target_compile_definitions(... PRIVATE "PCL_ROS_BUILDING_LIBRARY")`. This approach is documented here: https://docs.ros.org/en/jazzy/The-ROS2-Project/Contributing/Windows-Tips-and-Tricks.html
Thank you for your reply. I see moveit2 is indeed using `CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS`. While visibility control macros are the preffered way of working, I think it is indeed a major change...
Can you rebase your changes on top of the ros2 branch? Then we can see if the CI succeeds for rolling & kilted.
I don't see any objections here, so I'll merge it