Darshan Sen
Darshan Sen
I didn't get a chance to try to package an electron app using electron-builder yet but the reason why this happens is clear - https://github.com/electron/electron/blob/31be6ecf7b1e63f278b03c5d64d59288ee2f1cd7/shell/browser/api/electron_api_app.cc#L988-L1003. `app.isPackaged` works by checking if...
@message163 I tried to package a dummy app using electron-builder v23.3.3 on Windows and I wasn't able to repro this locally because the name of the executable is the same...
No follow-up for more than a month, closing.
@ljharb @BridgeAR Is there a minimum waiting time before we can land this PR and make a new release? I couldn't find any documentation for the process.
ping @goto-bus-stop ^
@luyahan it's true that it's not used inside `src/` but we do have some code in `lib/` that runs [`internal/freeze_intrinsics`](https://github.com/nodejs/node/blob/d5d7a416c72a46a91dbe2daf14239a55143a52f8/lib/internal/freeze_intrinsics.js) if the option is passed, see - https://github.com/nodejs/node/blob/d5d7a416c72a46a91dbe2daf14239a55143a52f8/lib/internal/process/pre_execution.js#L611-L615
`tsc-review` was removed in https://github.com/nodejs/node/pull/26506. Any chance you wanted to apply the https://github.com/nodejs/admin/labels/tsc-agenda label, so that this issue gets mentioned in the next meeting for awareness purposes? FWIW, this issue...
Doesn't GitHub already provide something like that (https://github.com/ovflowd?tab=achievements in your case)? I'm not sure how Holopin is different from that, could you please elaborate? Also what does it mean for...
This was also an issue in macOS, so I sent a fix for it in https://github.com/electron/electron/pull/33734. :)