Darshan Sen

`tty_escape_sequence_processing` and `tty_set_style` fail on Windows

1

* **Version**: `v1.x` * **Platform**: `MSYS_NT-10.0-17763 EC2AMAZ-0TC2IUC 3.1.7-340.x86_64 2021-03-26 22:17 UTC x86_64 Msys` * **Compiler**: Microsoft Visual Studio 2019 The following tests fail: ```console $ ctest -C Debug --output-on-failure ......

`run script` does not measure coverage of the shell script

3

# Bug 🐞 ## Description Just as the docs for `run source` (https://github.com/shellspec/shellspec#using-run-source) mentions, the corresponding docs for `run script` (https://github.com/shellspec/shellspec#using-run-script) too says that a coverage should be measured for...

Implement `assert.match()` and `assert.doesNotMatch()`

4

Signed-off-by: Darshan Sen

I noticed that the preview URLs for the PRs don't contain the committed changes. Refs: * https://github.com/v8/v8.dev/pull/497 * https://github.com/v8/v8.dev/pull/494 Maybe [this issue](https://github.com/actions/checkout/issues/237) is still persisting. Should we use `@actions/checkout@v1` instead?

Update the sample output in `example/default-metrics.js`

1

This updates the outdated sample output with the latest one we get when we run the script using Node.js v17.4.0 on an x86_64 Ubuntu 20.04. Signed-off-by: Darshan Sen

Onboarding F3n67u to the build wg

7

While I was onboarding @F3n67u as a collaborator yesterday, I followed the [onboarding guide in the core repo](https://github.com/nodejs/node/blob/main/onboarding.md) and it mentions this: https://github.com/nodejs/node/blob/main/onboarding.md#fifteen-minutes-before-the-onboarding-session > ## Fifteen minutes before the onboarding...

test: add test for `Module._stat`

6

`Module._stat` landed in https://github.com/nodejs/node/pull/44537 without a test, so this change adds one. Signed-off-by: Darshan Sen

In Node.js, `fs.readlink()` on a non-symlink file used to throw an `UNKNOWN` error on Windows. This change maps `ERROR_NOT_A_REPARSE_POINT` to `UV_EINVAL`, so that now it throws `EINVAL` just like all...

How to lint directory names with extensions without using a regex?

1

I'm trying to lint the name of iconset directories. I was using snake case for all directory names, so previously my rule was: ```yml ls: .dir: snake_case ``` but now...

Support snapshotting node:test

3

### Version v20.0.0 ### Platform _No response_ ### Subsystem bootstrap ### What steps will reproduce the bug? ```py $ cat input.js require('node:test') $ lldb -- $(command -v node) --snapshot-blob snapshot.blob...