Darshan Sen comments

Results 87 comments of


                                            Darshan Sen

Use `process.getActiveResourcesInfo()` instead of `process._activeHandles()`

Looking at the uses of `process._activeHandles()` in this repo: * https://github.com/clinicjs/node-clinic-doctor/blob/efd85ff33c3006c025901fb94d7c6db0f7061f05/collect/process-stat.js#L52 * https://github.com/clinicjs/node-clinic-doctor/blob/efd85ff33c3006c025901fb94d7c6db0f7061f05/test/collect-process-stat.test.js#L37 it looks like the use case here is to track the number of active handles. Is that...

Use `process.getActiveResourcesInfo()` instead of `process._activeHandles()`

Okay, in that case, maybe a semver-major release with this change would be an acceptable solution?

src,lib: reducing C++ calls of esm legacy main resolve

@H4ad does https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#how-to-submit-a-backport-pull-request help?

Support snapshotting node:test

cc @joyeecheung

fix: harden check for non-module in vm.modules linker

Should we add a test? Also, cc @nodejs/vm.

fix: harden check for non-module in vm.modules linker

I think so, yes.

fix: harden check for non-module in vm.modules linker

Yea, you can run `./node test/parallel/test-rest-of-the-file-name.js` to run an individual test

sea: snapshot support in single executable applications

Thanks for doing this! > add some tooling to process the inputs I personally really like this approach. I've opened a discussion in https://github.com/nodejs/single-executable/discussions/58, so that we can have a...

sea: snapshot support in single executable applications

I can try to take a look day after tomorrow. (I'll be traveling pretty much the entire day tomorrow)

process: add _getActiveHandles documentation

PR to make it public: https://github.com/nodejs/node/pull/37262