admin icon indicating copy to clipboard operation
admin copied to clipboard

Enable GitHub Codespaces for Node.js

Open ovflowd opened this issue 2 years ago • 17 comments

Recently, the OpenJS Foundation pivoted, enabling Codespaces Billing on the Webpack organisation (https://github.com/openjs-foundation/cross-project-council/issues/1009). I'd like the same to be done on the Node.js organisation.

I can see clear benefits in productivity as we could access the large Codepsaces Runners and build Node.js on the cloud if needed. Also, it would bring benefits where collaborators are far from their development machines but could still contribute.

At least I'm already using it daily for the Website Team, but paying from my pocket.

I don't know if this needs TSC consensus. cc @nodejs/tsc

ovflowd avatar Jul 06 '23 10:07 ovflowd

cc @mhdawson

ovflowd avatar Jul 06 '23 10:07 ovflowd

SGTM as long as we have the budget for it and it is not abused.

targos avatar Jul 06 '23 12:07 targos

SGTM as long as we have the budget for it and it is not abused.

We should probably enable only specific repositories. Afaik, this is configurable. And we can keep track of the billing to see who users are potentially abusing the system.

ovflowd avatar Jul 06 '23 12:07 ovflowd

sgtm

mcollina avatar Jul 06 '23 21:07 mcollina

Do we need to add this to the TSC agenda, or is this sgtm enough to the point of simply requesting the Foundation to do it?

Or are there any further details to be done?

ovflowd avatar Jul 10 '23 14:07 ovflowd

Probably a good idea to add it to a TSC agenda for awareness purposes, but also I'd consider open-for-5-days-with-2-approvals-from-TSC-members sufficient to make the request.

And it SGTM too, so that's three TSC members.

Trott avatar Jul 11 '23 15:07 Trott

SGTM

BridgeAR avatar Jul 11 '23 16:07 BridgeAR

@Trott was there any review? Or any update? Or does tsc-review only means, awaiting for TSC members to approve?

ovflowd avatar Aug 03 '23 08:08 ovflowd

tsc-review was removed in https://github.com/nodejs/node/pull/26506. Any chance you wanted to apply the https://github.com/nodejs/admin/labels/tsc-agenda label, so that this issue gets mentioned in the next meeting for awareness purposes? FWIW, this issue was very briefly mentioned in https://www.youtube.com/live/ikPN11Qksl8?feature=share&t=373 but no review happened on the meeting.

RaisinTen avatar Aug 03 '23 08:08 RaisinTen

Hmm, yeah I guess tsc-agenda then?

ovflowd avatar Aug 03 '23 11:08 ovflowd

@ovflowd can you confirm that if we enable, it will only be able to be used up to the $ that the Foundation has provided? If so then I'm STGM as well.

mhdawson avatar Aug 03 '23 17:08 mhdawson

Hey @mhdawson according to this https://github.com/openjs-foundation/cross-project-council/blob/main/project-resources/REQUESTING_GITHUB_RESOURCES.md, yes.

(And I double-checked with Ben). He would need to be added as Billing Manager (as stated in the doc) and then we can put limits, limit how many codespaces each user can create, we can even limit which repositories can have codespaces (billed to the Node.js org) and even limit who can have access to it (if we want to make it opt-in)

ovflowd avatar Aug 03 '23 18:08 ovflowd

LGTM

mhdawson avatar Aug 03 '23 18:08 mhdawson

@mhdawson let me know once there's an update on the next TSC meeting, so depending of the outcome I'd be able to forward this to the CPC :)

ovflowd avatar Aug 07 '23 17:08 ovflowd

@ovflowd its on the agenda for the TSC meeting this week. I'll let you know the outcome of any discussion.

mhdawson avatar Aug 14 '23 18:08 mhdawson

SGTM, approved in today's TSC meeting

mcollina avatar Aug 16 '23 13:08 mcollina

Opened a PR on the Foundation's CPC repository: https://github.com/openjs-foundation/cross-project-council/pull/1149

ovflowd avatar Aug 16 '23 19:08 ovflowd