Darshan Sen comments

Results 54 comments of


                                            Darshan Sen

fix: app.relaunch loses args when execPath specified

> I don't have a local toolchain to do the full build/test. Could someone please check this for me? Maybe you could write a test with [your gist](https://gist.github.com/p120ph37/98cf0fb13790feed702f3e90cbddfbf6) and we'll...

fix: app.relaunch loses args when execPath specified

> I wasn't able to test initially, because I don't have a working build toolchain, but after filing this PR, I was able to use the CircleCI build output to...

[Bug]: session.webRequest in main process can not catch WebSocket using socket.io-client

Reopening since the OP stated that they're using `socket.io-client` and not `socket.io` which uses `net` / `tls` from node.

app. Ispackaged is also false after it is packaged by electronic builder

what do you get when you print `app.getPath('exe')`?

Add glob support to ignores

Gentle ping @loeffel-io, just wanted to make sure that you didn't forget about this PR 😅

Nominating @daeyeon as a collaborator

+1!

`run script` does not measure coverage of the shell script

@CGForeau Hi. I guess this is platform specific then. I have updated the ticket with my system info. On macOs, `/bin/sh` is the bash shell. PTAL.

Improve Object::get_own_property_names()

I worked on a fix for this today - https://github.com/denoland/rusty_v8/pull/1049 :)

Update the sample output in `example/default-metrics.js`

cc @zbjornson

Clarify moderation reporting requirements

Pinging @nodejs/moderation again because there's a typo in the team name in the PR description and simply editing that probably won't send a notification to them.