Ethan Mahintorabi
Ethan Mahintorabi
You need to sign off your git commits with the -s flag. https://github.com/The-OpenROAD-Project/OpenROAD/pull/2696/checks?check_run_id=10416684588
@mguthaus You need to amend d3d33f85e1a1cfd2db3153be03fff0e2abc94880 with a `git rebase HEAD~2 -s` then force push to make the DCO pass.
I've run into this before. I just downloaded the clang-format version that's in the CI, and used that one. 18.1.3
incremental02 does seem to return a different DEF file as compared to the cmake build. It's likely it just comes down to a different compiler or compiler options
It looks like this file is trying to distinguish between c++ and c. I added -x c++ to all the abc files in bazel rules maybe it needs some kind...
Perhaps it wants a -latomic in the link opts? https://github.com/hdl/bazel_rules_hdl/blob/main/dependency_support/edu_berkeley_abc/bundled.BUILD.bazel#L1220
@oharboe I'm not an expert in this area, but a longer clock tree usually implies more structure. Which means that you have more structures susceptible to on chip variation (OCV)....
@calewis could you review this PR from antmicro?
Yeah I'll own it
Will review today