OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

RSZ: Remove non-determinism and platform-specific behavior

Open calewis opened this issue 3 weeks ago • 13 comments

Fix non-determinism in Resizer that caused flaky tests. This enables pin_swap1 and resize_slacks2 to run by default in Bazel tests.

Note: Some tests remain flaky if write_verilog is called without --sort. This is deferred to an upstream STA update that will enforce deterministic sorting by default.

calewis avatar Dec 05 '25 19:12 calewis

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 05 '25 19:12 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 05 '25 19:12 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 05 '25 19:12 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 05 '25 19:12 github-actions[bot]

Looks like clang-format on ranges stuff might change between versions, my file is formatted, by my clang-format.

calewis avatar Dec 05 '25 20:12 calewis

I've run into this before. I just downloaded the clang-format version that's in the CI, and used that one. 18.1.3

QuantamHD avatar Dec 05 '25 20:12 QuantamHD

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 05 '25 21:12 github-actions[bot]

I've run into this before. I just downloaded the clang-format version that's in the CI, and used that one. 18.1.3

Was able to use apt install clang-format-18 and that one matches well enough.

calewis avatar Dec 05 '25 22:12 calewis

I've run into this before. I just downloaded the clang-format version that's in the CI, and used that one. 18.1.3

Add a bazelisk run //:format target to insulate ourselves from locally installed tools?

This would autoformat

  • python
  • tcl
  • bazel
  • C++

oharboe avatar Dec 07 '25 20:12 oharboe

That sounds useful

maliberty avatar Dec 08 '25 15:12 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 08 '25 17:12 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 08 '25 17:12 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Dec 08 '25 23:12 github-actions[bot]