OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

DO NOT MERGE: Add slew violation check to size_down, re-enable size_down.

Open mguthaus opened this issue 6 months ago • 4 comments

Don't merge yet, doing PR to get QoR results.

mguthaus avatar Jun 08 '25 17:06 mguthaus

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 08 '25 17:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 11 '25 19:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 11 '25 19:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 17 '25 23:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 18 '25 14:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 11 '25 18:07 github-actions[bot]

@mguthaus You need to amend d3d33f85e1a1cfd2db3153be03fff0e2abc94880 with a git rebase HEAD~2 -s then force push to make the DCO pass.

QuantamHD avatar Jul 11 '25 19:07 QuantamHD

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 11 '25 20:07 github-actions[bot]

@povik Can you take a look? I think I've got general improvement in QoR in most cases.

mguthaus avatar Jul 11 '25 21:07 mguthaus

Or can @maliberty take a look?

mguthaus avatar Jul 11 '25 21:07 mguthaus

@mguthaus I've started a run to evaluate QoR on ORFS. I will try to review the code

povik avatar Jul 14 '25 13:07 povik

@mguthaus QoR comparison with a clean baseline (no other changes should be interfering): https://dashboard.precisioninno.com/compare?sourceAType=Commit&sourceBType=Commit&sourceBName=1171cb1d34e470c433f8eb5baef6b71213e6a920&sourceBID=1&sourceAName=4a04de24f4b308603ad92c9206633347015530cd&sourceAID=5753

I don't see any notable degradation.

povik avatar Jul 17 '25 12:07 povik

Cool comparison tool.

It seems there is consistent finish__power__total and finish__design__core__area improvement in most designs (none got worse). This is expected since this is using downsizing to get improvement.

finish__timing__setup__ws and finish__timing__setup__tns results are a bit mixed but with more improvement than not. (Maybe I'm being subjective...). I think this also makes sense because other moves would get a similar result (albeit using more power).

Also, there is no degredatation in finish__runtime__total which was my main concern on larger designs.

mguthaus avatar Jul 17 '25 13:07 mguthaus

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 17 '25 14:07 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 29 '25 22:07 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 29 '25 23:07 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 31 '25 19:07 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 01 '25 23:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 01 '25 23:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 05 '25 16:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 12 '25 23:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 13 '25 19:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 13 '25 19:08 github-actions[bot]

@povik Can you take a lok?

mguthaus avatar Aug 15 '25 17:08 mguthaus

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 25 '25 22:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 26 '25 17:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 26 '25 17:09 github-actions[bot]

@povik Can you take a look again? I believe I fixed all prior issues.

Results in setup slack are mixed tending to improved slack. But this is because the one path at a time repair setup needs to be improved and is in a local minima. It gets consistent power improvement with similar slack in all other cases.

mguthaus avatar Oct 01 '25 14:10 mguthaus

I see merge conflicts to resolve. Is this otherwise ready for testing?

maliberty avatar Oct 08 '25 22:10 maliberty

I see merge conflicts to resolve. Is this otherwise ready for testing?

I rebased and pushed, but it fails clang-tidy due to the CI issues, I believe?

mguthaus avatar Oct 08 '25 23:10 mguthaus